This repository has been archived by the owner on Nov 2, 2024. It is now read-only.
feat: Support configuration-based provisioning of Cloud Ops artifacts (part 2) #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minherz
force-pushed
the
minherz/implement-configuration
branch
from
0982a70
to
5be5b46
Compare
minherz
force-pushed
the
milestone/0.10
branch
from
66bcbde
to
cb38bb8
Compare
Add placeholders for 'microservice-demo' folders. Rename 'online-boutique' to 'microservice-demo'. Refactor sandboxctl CLI script.
minherz
force-pushed
the
minherz/implement-configuration
branch
from
5be5b46
to
515fb31
Compare
Rename the module from microservice-demo to microservices-demo. Update the input parameters. Document changes. Move install_asm.sh script to be inside the module.
Fix errors in the documentation README file including: - bad links - incorrect commands
|
PR is closed in favor of alternative implementation path. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Change the provisioning of the Cloud Ops Sandbox artifacts from being hardcoded in Terraform to the configured using external YAML files. Terraform will process the configuration's files to provision the same set of artifacts from the configuration. The specific configuration is determined based on the configuration's ID and the constant root path within the repository (i.e.
configurations/{ID}).This PR includes:
/configurations/test) to include validations required for provisioning microservice-demo Cloud Ops Sandbox Sandbox./provisioning/terraform/microservice-demo.Which issue(s) this PR fixes:
Fixes #1020
Fixes #1026
Fixes #1037
Special notes for a reviewer:
See for feat: Support configuration-based provisioning of Cloud Ops artifacts (part 1) PR #1036